lostluck commented on a change in pull request #14513:
URL: https://github.com/apache/beam/pull/14513#discussion_r612812980
##########
File path: sdks/java/container/boot.go
##########
@@ -115,6 +115,7 @@ func main() {
os.Setenv("PIPELINE_OPTIONS", options)
os.Setenv("LOGGING_API_SERVICE_DESCRIPTOR",
proto.MarshalTextString(&pipepb.ApiServiceDescriptor{Url: *loggingEndpoint}))
os.Setenv("CONTROL_API_SERVICE_DESCRIPTOR",
proto.MarshalTextString(&pipepb.ApiServiceDescriptor{Url: *controlEndpoint}))
+ os.Setenv("RUNNER_CAPABILITIES", strings.Join(" ",
info.GetRunnerCapabilities()))
Review comment:
https://golang.org/pkg/strings/#Join
You've swapped the parameter order to strings.Join, the join separator is
2nd.
```suggestion
os.Setenv("RUNNER_CAPABILITIES",
strings.Join(info.GetRunnerCapabilities(), " "))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
