lostluck commented on a change in pull request #14513:
URL: https://github.com/apache/beam/pull/14513#discussion_r613398324
##########
File path: sdks/python/container/boot.go
##########
@@ -185,6 +185,7 @@ func main() {
os.Setenv("SEMI_PERSISTENT_DIRECTORY", *semiPersistDir)
os.Setenv("LOGGING_API_SERVICE_DESCRIPTOR",
proto.MarshalTextString(&pipepb.ApiServiceDescriptor{Url: *loggingEndpoint}))
os.Setenv("CONTROL_API_SERVICE_DESCRIPTOR",
proto.MarshalTextString(&pipepb.ApiServiceDescriptor{Url: *controlEndpoint}))
+ os.Setenv("RUNNER_CAPABILITIES", strings.Join(" ",
info.GetRunnerCapabilities()))
Review comment:
Same here. Parameter order is wrong for strings.Join. list then sep.
Though, until the Go proto update is patched in, it still won't compile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
