TheNeuralBit commented on a change in pull request #14438:
URL: https://github.com/apache/beam/pull/14438#discussion_r616167616
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -922,33 +923,79 @@ def dropna(self, **kwargs):
to_string = frame_base.wont_implement_method(
pd.Series, 'to_string', reason="non-deferred-result")
- def aggregate(self, func, axis=0, *args, **kwargs):
+ @frame_base.args_to_kwargs(pd.Series)
+ @frame_base.populate_defaults(pd.Series)
+ def aggregate(self, func, axis, *args, **kwargs):
Review comment:
That's actually what `frame_base.populate_defaults` does. It creates a
wrapper method that has the same arguments, but with defaults populated from
the equivalent pandas method. So this will end up with `axis=0` as the default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
