TheNeuralBit commented on a change in pull request #14438:
URL: https://github.com/apache/beam/pull/14438#discussion_r616239454
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -922,33 +923,79 @@ def dropna(self, **kwargs):
to_string = frame_base.wont_implement_method(
pd.Series, 'to_string', reason="non-deferred-result")
- def aggregate(self, func, axis=0, *args, **kwargs):
+ @frame_base.args_to_kwargs(pd.Series)
+ @frame_base.populate_defaults(pd.Series)
+ def aggregate(self, func, axis, *args, **kwargs):
Review comment:
Doing it programmatically keeps the pandas implementation as the single
source of truth for these defaults, so we don't need to worry about
inadvertently diverging (either because pandas changes them, or we mistakenly
set the wrong default).
@robertwb actually added this so he may have some additional insight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
