TheNeuralBit commented on a change in pull request #14390:
URL: https://github.com/apache/beam/pull/14390#discussion_r616230075
##########
File path: sdks/python/apache_beam/runners/pipeline_context.py
##########
@@ -118,13 +120,19 @@ def get_by_id(self, id):
def get_by_proto(self, maybe_new_proto, label=None, deduplicate=False):
# type: (message.Message, Optional[str], bool) -> str
+ obj = self._obj_type.from_runner_api(
Review comment:
Hm I'll need to spend my time to jog my memory on this. I think I may
have naively propagated some existing logic, prior to #12067 the return
statement was:
```
return self.put_proto(self._unique_ref(label), maybe_new_proto)
```
And the first argument of `unique_ref` is `obj`. I vaguely recall puzzling
over this for a while.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
