TheNeuralBit commented on a change in pull request #14390:
URL: https://github.com/apache/beam/pull/14390#discussion_r616234795
##########
File path: sdks/python/apache_beam/runners/pipeline_context.py
##########
@@ -118,13 +120,19 @@ def get_by_id(self, id):
def get_by_proto(self, maybe_new_proto, label=None, deduplicate=False):
# type: (message.Message, Optional[str], bool) -> str
+ obj = self._obj_type.from_runner_api(
Review comment:
Passing label to `unique_ref`'s obj arg goes back as long as
`get_by_proto` has existed. See https://github.com/apache/beam/pull/7729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
