tvalentyn commented on a change in pull request #14390:
URL: https://github.com/apache/beam/pull/14390#discussion_r616249709
##########
File path: sdks/python/apache_beam/runners/pipeline_context.py
##########
@@ -118,13 +120,19 @@ def get_by_id(self, id):
def get_by_proto(self, maybe_new_proto, label=None, deduplicate=False):
# type: (message.Message, Optional[str], bool) -> str
+ obj = self._obj_type.from_runner_api(
Review comment:
It seems like `get_by_proto` has no usage outside of tests and this PR.
I can look into deleting this method altogether and find another solution
for my purposes. Alternatively, I can assert that the input is an Environment
for now and/or some 'allowed' entities (Coders?) where XLang concerns don't
apply
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
