tvalentyn commented on a change in pull request #14390:
URL: https://github.com/apache/beam/pull/14390#discussion_r616894111
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -1317,6 +1336,15 @@ def from_runner_api(
pc.tag = None if tag == 'None' else tag
return result
+ def _merge_outer_resource_hints(self):
+ if (self.parent is not None and self.parent.resource_hints):
+ merge_resource_hints(
+ outer_hints=self.parent.resource_hints,
+ mutable_inner_hints=self.resource_hints)
Review comment:
Agreed. Also without mutations we can store hints under an envelope of a
MappingProxyType to return immutable dicts throughout. Wonder about your
thoughts on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
