suztomo commented on a change in pull request #14578:
URL: https://github.com/apache/beam/pull/14578#discussion_r619328009
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/SubscriberOptions.java
##########
@@ -86,11 +107,31 @@
public static Builder newBuilder() {
Builder builder = new AutoValue_SubscriberOptions.Builder();
- return
builder.setPartitions(ImmutableSet.of()).setFlowControlSettings(DEFAULT_FLOW_CONTROL);
+ return builder
+ .setPartitions(ImmutableSet.of())
+ .setFlowControlSettings(DEFAULT_FLOW_CONTROL)
+ .setMinBundleTimeout(MIN_BUNDLE_TIMEOUT);
}
public abstract Builder toBuilder();
+ private SubscriberServiceClient newSubscriberServiceClient(Partition
partition)
+ throws ApiException {
+ try {
+ SubscriberServiceSettings.Builder settingsBuilder =
SubscriberServiceSettings.newBuilder();
+
+ settingsBuilder =
+ addDefaultMetadata(
+ PubsubContext.of(FRAMEWORK),
+ RoutingMetadata.of(subscriptionPath(), partition),
+ settingsBuilder);
Review comment:
Memo: This assignment to `settingsBuilder` is unnecessary, but without
that error prone gives error for ignoring the return value of the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
