tvalentyn commented on a change in pull request #14607:
URL: https://github.com/apache/beam/pull/14607#discussion_r619549054
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SdkComponents.java
##########
@@ -304,7 +304,7 @@ public String registerEnvironment(Environment env) {
if (existing != null) {
environmentId = existing;
} else {
- String name = uniqify(env.getUrn() + "_", environmentIds.values());
Review comment:
Removing this from here, adding to uniqify would be a proper place, but
I am not sure whether any other logic that uses uniqify assumes current pattern
in tests etc... so leaving as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
