tvalentyn commented on a change in pull request #14607:
URL: https://github.com/apache/beam/pull/14607#discussion_r621510408
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
##########
@@ -760,6 +776,24 @@ private void addDisplayData(Step step, String stepName,
HasDisplayData hasDispla
List<Map<String, Object>> list = MAPPER.convertValue(displayData,
List.class);
addList(getProperties(), PropertyNames.DISPLAY_DATA, list);
}
+
+ private void addResourceHints(Step step, String stepName, ResourceHints
hints) {
+ Map<String, Object> urlEncodedHints = new HashMap<>();
+ PercentCodec codec = new PercentCodec();
+ for (Entry<String, ResourceHint> entry : hints.hints().entrySet()) {
+ try {
Review comment:
Another nice thing about Apache Commons codec is that it understands
bytearray, URLEncoder will require another string conversion. I think it's fine
to keep as is, but if you feel strongly we should change to URLEnconder I'm
happy to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
