ernvalentino commented on a change in pull request #14644:
URL: https://github.com/apache/beam/pull/14644#discussion_r621393777
##########
File path:
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##########
@@ -1154,6 +1154,8 @@ public static Sink sink(Schema schema) {
abstract int getRowGroupSize();
+ abstract @Nullable Class<? extends GenericData> getAvroDataModel();
Review comment:
it needs to be serializable, since this is passed to the `DoFn`
responsible for writing. The reader does the same way in the
[`ReadFn`](https://github.com/apache/beam/blob/master/sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java#L1069)
and
[`SplitReadFn`](https://github.com/apache/beam/blob/master/sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java#L810)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
