aromanenko-dev commented on a change in pull request #14644:
URL: https://github.com/apache/beam/pull/14644#discussion_r621991613
##########
File path:
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##########
@@ -1154,6 +1154,8 @@ public static Sink sink(Schema schema) {
abstract int getRowGroupSize();
+ abstract @Nullable Class<? extends GenericData> getAvroDataModel();
Review comment:
Yes but my concern is that we have a little bit different builder's API
for Read (returns `GenericData`) and Write (returns `Class<? extends
GenericData>`) parts. Well, I think we can leave it at "it is" since only
`withAvroDataModel(GenericData model)` is a public user's API and it's the same
for both parts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
