BenWhitehead commented on a change in pull request #14261:
URL: https://github.com/apache/beam/pull/14261#discussion_r627824595
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/RpcQosImpl.java
##########
@@ -204,7 +210,8 @@ public boolean awaitSafeToProceed(Instant instant) throws
InterruptedException {
state.checkActive();
Duration shouldThrottleRequest = at.shouldThrottleRequest(instant);
if (shouldThrottleRequest.compareTo(Duration.ZERO) > 0) {
- logger.info("Delaying request by {}ms",
shouldThrottleRequest.getMillis());
+ long throttleRequestMillis = shouldThrottleRequest.getMillis();
+ logger.debug("Delaying request by {}ms", throttleRequestMillis);
Review comment:
I dropped it to debug after adding the diagnostic distribution
`qos_adaptiveThrottler_throttlingMs` so as not to blow out logs as this
scenario can happen thousands of times for a job.
This screenshot shows the average number of times the adaptive throttler
throttled grouped by docCount and fieldCount.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
