BenWhitehead commented on a change in pull request #14261:
URL: https://github.com/apache/beam/pull/14261#discussion_r627825490
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/RpcQosImpl.java
##########
@@ -344,7 +354,8 @@ public boolean awaitSafeToProceed(Instant instant) throws
InterruptedException {
Optional<Duration> shouldThrottle = writeRampUp.shouldThrottle(instant);
if (shouldThrottle.isPresent()) {
Duration throttleDuration = shouldThrottle.get();
- getLogger().debug("Still ramping up, Delaying request by {}ms",
throttleDuration.getMillis());
+ long throttleDurationMillis = throttleDuration.getMillis();
+ getLogger().debug("Still ramping up, Delaying request by {}ms",
throttleDurationMillis);
Review comment:
Similar to adaptive throttler, this can happen a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
