TheNeuralBit commented on a change in pull request #14720:
URL: https://github.com/apache/beam/pull/14720#discussion_r628521590
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ReshuffleTest.java
##########
@@ -274,4 +277,26 @@ public void testReshuffleWithTimestampsStreaming() {
pipeline.run();
}
+
+ @Test
+ @Category({ValidatesRunner.class, UsesTestStream.class})
+ public void testAssignShardFn() {
+
+ PCollection<KV<String, Integer>> input =
+ pipeline
+ .apply(
+ Create.of(ARBITRARY_KVS)
+ .withCoder(KvCoder.of(StringUtf8Coder.of(),
VarIntCoder.of())))
+ .apply(Window.into(new GlobalWindows()));
Review comment:
The hashing in Reshuffle (and the values in ARBITRARY_KVS) is
deterministic right?
We don't need to worry about this flaking and ssometimes not producing a
value in every bucket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
