iemejia commented on a change in pull request #14720:
URL: https://github.com/apache/beam/pull/14720#discussion_r628697966
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ReshuffleTest.java
##########
@@ -274,4 +277,26 @@ public void testReshuffleWithTimestampsStreaming() {
pipeline.run();
}
+
+ @Test
+ @Category({ValidatesRunner.class, UsesTestStream.class})
Review comment:
Is `TestStream` used in this test? otherwise we should remove the
`UsesTestStream` annotation or the test won't be run for some runners.
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ReshuffleTest.java
##########
@@ -274,4 +277,26 @@ public void testReshuffleWithTimestampsStreaming() {
pipeline.run();
}
+
+ @Test
+ @Category({ValidatesRunner.class, UsesTestStream.class})
+ public void testAssignShardFn() {
+
+ PCollection<KV<String, Integer>> input =
+ pipeline
+ .apply(
+ Create.of(ARBITRARY_KVS)
+ .withCoder(KvCoder.of(StringUtf8Coder.of(),
VarIntCoder.of())))
+ .apply(Window.into(new GlobalWindows()));
Review comment:
Is forcing windowing into GlobalWindows necessary here given that it is
already a Bounded PCollection?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
