echauchot commented on a change in pull request #14347:
URL: https://github.com/apache/beam/pull/14347#discussion_r629328260
##########
File path:
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
##########
@@ -158,10 +167,16 @@
})
public class ElasticsearchIO {
Review comment:
Right now, the main ESIO javadoc lists only part of the options. I think
that having all the with* options in main javadoc is source of out of date
javadocs. Please update both read and write to specify only mandatory option
such as withConfiguration and mention that the IO can be configured in
different ways see the with* methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
