echauchot commented on a change in pull request #14347:
URL: https://github.com/apache/beam/pull/14347#discussion_r629360627
##########
File path:
sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTestCommon.java
##########
@@ -265,6 +275,13 @@ void testWriteWithErrors() throws Exception {
List<String> input =
ElasticsearchIOTestUtils.createDocuments(
numDocs,
ElasticsearchIOTestUtils.InjectionMode.INJECT_SOME_INVALID_DOCS);
+
Review comment:
I think you missed that one: the code below is duplicated among tests
and should be extracted to a method in ESTestUtils.
`List<String> serializedInput = new ArrayList<>();
for (String doc : input) {
serializedInput.add(
DocToBulk.createBulkApiEntity(
write.getDocToBulk(), doc,
getBackendVersion(connectionConfiguration)));
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
