ibzib commented on pull request #14785:
URL: https://github.com/apache/beam/pull/14785#issuecomment-839318007


   > Well I guess this can still flake with the increased timeout.
   > 
   > Perhaps there's another bug that causes the success signal to never fire? 
Maybe add some logging in the `resultSignal.signalSuccessWhen` function to see 
if it's receiving some non-matching element.
   
   I tried lowering the timeout back to 1m and ran the test with some 
additional logs. It looks like all of the right elements are produced, but 
TestPubsubSignal is never receiving the SUCCESS message. TBH I'm not sure why 
we use TestPubsubSignal instead of a regular PAssert here -- especially when 
signaling via pubsub seems like an additional source of flakiness.
   
   ```
   INFO: Entries: {3=foo}
   May 11, 2021 4:25:05 PM 
org.apache.beam.sdk.extensions.sql.meta.provider.pubsub.PubsubTableProviderIT 
lambda$testSQLSelectsArrayAttributes$43268ee4$1
   INFO: Entries: {3=foo, 5=bar}
   May 11, 2021 4:25:05 PM 
org.apache.beam.sdk.extensions.sql.meta.provider.pubsub.PubsubTableProviderIT 
lambda$testSQLSelectsArrayAttributes$43268ee4$1
   INFO: Entries: {3=foo, 5=bar, 7=baz}
   
   Did not receive signal on 
projects/apache-beam-testing/subscriptions/result-subscription-7546269619304811750
 in 60s
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to