TheNeuralBit commented on pull request #14785: URL: https://github.com/apache/beam/pull/14785#issuecomment-842500399
> TBH I'm not sure why we use TestPubsubSignal instead of a regular PAssert here -- especially when signaling via pubsub seems like an additional source of flakiness. Good point, I'm not sure either. AFAICT the only thing we _need_ `TestPubsubSignal` for is to get a signal when the pipeline starts so we know when to start injecting input data. Perhaps we should replace all usages of signalSuccessWhen with a PAssert and get rid of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
