egalpin commented on pull request #14720:
URL: https://github.com/apache/beam/pull/14720#issuecomment-839777525


   @kennknowles I believe it could be tested via `Reshuffle.withNumBuckets` and 
then verifying the number of groups in the output PCollection was as expected.  
That said, now that `AssignShardFn` is `public`, is it preferable to have tests 
directly interacting with the class? I'm not sure what the practice is across 
the code base, happy to adjust to fit!
   
   I do think in either case we'll see this odd `unboxing` error during 
compilation though. I still haven't gotten to the bottom of that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to