lazylynx commented on a change in pull request #14752:
URL: https://github.com/apache/beam/pull/14752#discussion_r635264891
##########
File path: sdks/python/apache_beam/typehints/decorators.py
##########
@@ -743,7 +622,7 @@ def _normalize_var_keyword_hint(hint, arg_name):
return typehints.Dict[str, typehints.Union[values]]
-def getcallargs_forhints_impl_py3(func, type_args, type_kwargs):
+def getcallargs_forhints(func, *type_args, **type_kwargs):
Review comment:
Yes, asterisks should be needed because signature.bind regard
`type_args` as tuple and `type_kwargs` as dict without them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]