kennknowles commented on a change in pull request #14698:
URL: https://github.com/apache/beam/pull/14698#discussion_r635277406
##########
File path: release/src/main/scripts/verify_release_build.sh
##########
@@ -123,12 +125,14 @@ if [[ ! -z `which hub` ]]; then
# The version change is needed for Dataflow python batch tests.
# Without changing to dev version, the dataflow pipeline will fail because
of non-existed worker containers.
# Note that dataflow worker containers should be built after RC has been
built.
- sed -i -e "s/${RELEASE_VER}/${RELEASE_VER}.dev/g"
sdks/python/apache_beam/version.py
- sed -i -e "s/sdk_version=${RELEASE_VER}/sdk_version=${RELEASE_VER}.dev/g"
gradle.properties
+ sh "$SCRIPT_DIR"/set_version.sh "$RELEASE_VER"
git add sdks/python/apache_beam/version.py
git add gradle.properties
+ # In case the version string was not changed, append a newline to CHANGES.md
+ echo "" >> CHANGES.md
+ git add CHANGES.md
Review comment:
If it wasn't changed, we don't want to commit it, right? Would `git add
--update` work? Or as a last resort there is `git add --ignore-errors` or I
guess even just `git add CHANGES.md || echo 'CHANGES.md not modified'`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
