echauchot commented on a change in pull request #14347:
URL: https://github.com/apache/beam/pull/14347#discussion_r637044281
##########
File path:
sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTestCommon.java
##########
@@ -532,6 +602,34 @@ void testWriteWithFullAddressing() throws Exception {
}
}
+ /**
+ * Tests that documents are correctly routed when index, type and document
ID functions are
+ * provided to overwrite the defaults of using the configuration and
auto-generation of the
+ * document IDs by Elasticsearch. The scientist name is used for the index,
type and document ID.
Review comment:
same as above it asserts count = numDocs / NUM_SCIENTISTS so javadoc is
to be updated no ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
