xinyuiscool commented on a change in pull request #14883:
URL: https://github.com/apache/beam/pull/14883#discussion_r640156561
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java
##########
@@ -274,10 +310,11 @@ public void translatePortable(
windowedInputCoder.getValueCoder(), // input coder not in use
windowedInputCoder,
Collections.emptyMap(), // output coders not in use
- Collections.emptyList(), // sideInputs not in use until side input
support
+ new ArrayList<>(
+ sideInputMapping.values()), // sideInputs not in use until
side input support
Review comment:
Yup, both are fine I guess so I picked sideInputMapping map. We actually
don't need to pass in both. There was some change from open source upstream to
add the map along with the view list. We can refactor this to remove this list
in the future, but I prefer doing it in another patch since this one is already
pretty big.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
