kw2542 commented on a change in pull request #14883:
URL: https://github.com/apache/beam/pull/14883#discussion_r640842393
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/GroupByKeyTranslator.java
##########
@@ -112,7 +112,21 @@ public void translatePortable(
PipelineNode.PTransformNode transform,
QueryablePipeline pipeline,
PortableTranslationContext ctx) {
- doTranslatePortable(transform, pipeline, ctx);
+ final String inputId = ctx.getInputId(transform);
Review comment:
why do we change the pattern to add impl in translatePortable instead of
doTranslatePortable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
