danthev commented on a change in pull request #14723:
URL: https://github.com/apache/beam/pull/14723#discussion_r641030864
##########
File path: sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py
##########
@@ -276,15 +277,33 @@ class _Mutate(PTransform):
Only idempotent Datastore mutation operations (upsert and delete) are
supported, as the commits are retried when failures occur.
"""
- def __init__(self, mutate_fn):
+
+ # Default hint for the expected number of workers in the ramp-up throttling
+ # step for write or delete operations.
+ _DEFAULT_HINT_NUM_WORKERS = 500
Review comment:
Bumping this because the edit to my previous comment is easy to miss.
The gist is that reporting throttling-msecs does not break autoscaling as far
as I can tell.
I did most of my testing with the Java implementation. I just noticed that
not only did I miss adding the throttling counter in the Python implementation,
but it appears Datastore only had a counter `cumulativeThrottlingSeconds`. Does
the metric work the same in Python, should the counter be called
`throttling-msecs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
