je-ik commented on a change in pull request #15082:
URL: https://github.com/apache/beam/pull/15082#discussion_r662120548
##########
File path:
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
##########
@@ -486,6 +504,11 @@ default InputT createInput(Pipeline p, Map<String,
PCollection<?>> inputs) {
.build();
}
+ protected Pipeline createPipeline() {
+ pipelineOptions.setRunner(NoOpRunner.class);
Review comment:
The problem is that `:sdks:java:expansion-service` would (in fact)
depend on :runners:direct-java`. It would require this at least for
`testRuntimeOnly`, but actually all uses of this module would need to add that
(or any other runner and specify --runner, but that will get ignored). I think
that the biggest problem is that runner is marked `@Validation.Required`,
athough it is not required (apparently, expansion service works without
runner). That is the root issue and everything else seems like a (smaller or
bigger) hack. Implementing a `NoOpRunner` seems like the smallest issue, as
that does not leak or break users anyhow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
