je-ik commented on a change in pull request #15082:
URL: https://github.com/apache/beam/pull/15082#discussion_r662123112
##########
File path:
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
##########
@@ -486,6 +504,11 @@ default InputT createInput(Pipeline p, Map<String,
PCollection<?>> inputs) {
.build();
}
+ protected Pipeline createPipeline() {
+ pipelineOptions.setRunner(NoOpRunner.class);
Review comment:
Hmm, maybe just deleting the `@Validation.Required` from `runner` in
`PipelineOptions` might be enough? What is the reasoning for having both
`@Validation.Required` and `@Default.InstanceFactory` on the same field? That
means that the field has default value - though will be present - and if it is
left to the default, it will throw the exception as soon as the Pipeline will
try to use it, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
