mattrudary commented on a change in pull request #15036:
URL: https://github.com/apache/beam/pull/15036#discussion_r666431710
##########
File path:
sdks/java/io/amazon-web-services/src/test/java/org/apache/beam/sdk/io/aws/s3/S3FileSystemTest.java
##########
@@ -107,59 +106,64 @@ public static void afterClass() {
@Test
public void testGetScheme() {
- S3FileSystem s3FileSystem = new S3FileSystem(s3Options());
+ S3FileSystem s3FileSystem = new S3FileSystem(s3Config("s3"));
Review comment:
OK, I've done this as much as possible by adding alternate versions of
the tests called e.g. testGetSchemaWithS3Options. These follow the original
test code closely, although S3ResourceIds have to be constructed with an
explicit scheme of "s3" in these cases.
##########
File path:
sdks/java/io/amazon-web-services/src/test/java/org/apache/beam/sdk/io/aws/s3/S3FileSystemTest.java
##########
@@ -107,59 +106,64 @@ public static void afterClass() {
@Test
public void testGetScheme() {
- S3FileSystem s3FileSystem = new S3FileSystem(s3Options());
+ S3FileSystem s3FileSystem = new S3FileSystem(s3Config("s3"));
Review comment:
OK, I've done this as much as possible by adding alternate versions of
the tests called e.g. testGetSchemeWithS3Options. These follow the original
test code closely, although S3ResourceIds have to be constructed with an
explicit scheme of "s3" in these cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
