mattrudary commented on a change in pull request #15036:
URL: https://github.com/apache/beam/pull/15036#discussion_r666441840
##########
File path:
sdks/java/io/amazon-web-services/src/test/java/org/apache/beam/sdk/io/aws/s3/S3WritableByteChannelTest.java
##########
@@ -60,29 +59,29 @@
@Test
public void write() throws IOException {
- writeFromOptions(s3Options());
Review comment:
I've rewritten the test as much as possible to support that, but in the
end the constructor takes a config instead of an options, and I think that's
what we want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
