rohdesamuel commented on a change in pull request #15165:
URL: https://github.com/apache/beam/pull/15165#discussion_r671465231
##########
File path: sdks/python/apache_beam/dataframe/pandas_doctests_test.py
##########
@@ -386,6 +394,7 @@ def test_series_tests(self):
],
'pandas.core.series.Series.fillna': [
"df.fillna(method='ffill')",
+ 'df.fillna(method="ffill")',
Review comment:
Pandas changed from single to double quotes in 1.3.0, so we need to add
this extra line in.
##########
File path: sdks/python/apache_beam/dataframe/pandas_doctests_test.py
##########
@@ -69,6 +69,7 @@ def test_ndframe_tests(self):
],
'pandas.core.generic.NDFrame.fillna': [
"df.fillna(method='ffill')",
+ 'df.fillna(method="ffill")',
Review comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
