aaltay commented on a change in pull request #15165:
URL: https://github.com/apache/beam/pull/15165#discussion_r674260722
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -3392,7 +3395,7 @@ def melt(self, ignore_index, **kwargs):
@frame_base.with_docs_from(pd.DataFrame)
def value_counts(self, subset=None, sort=False, normalize=False,
- ascending=False):
+ ascending=False, dropna=True):
Review comment:
I was not asking about the notice. I was asking should we change
dropna=True to dropna=False here in value_counts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
