xinyuiscool commented on a change in pull request #15280:
URL: https://github.com/apache/beam/pull/15280#discussion_r683860783
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java
##########
@@ -112,8 +113,10 @@ public void translate(
.collect(
Collectors.toMap(e -> e.getKey(), e -> ((PCollection<?>)
e.getValue()).getCoder()));
- boolean isStateful = DoFnSignatures.isStateful(transform.getFn());
- final Coder<?> keyCoder = isStateful ? ((KvCoder<?, ?>)
input.getCoder()).getKeyCoder() : null;
+ final Coder<?> keyCoder =
+ StateUtils.isStateful(transform.getFn())
Review comment:
I guess we might as well add a getKeyCoder() in the stateUtils to avoid
these logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
