kw2542 commented on a change in pull request #15280:
URL: https://github.com/apache/beam/pull/15280#discussion_r683877476
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java
##########
@@ -301,12 +304,18 @@ public void translatePortable(
final RunnerApi.PCollection input =
pipeline.getComponents().getPcollectionsOrThrow(inputId);
final PCollection.IsBounded isBounded =
SamzaPipelineTranslatorUtils.isBounded(input);
+ final Coder<?> keyCoder =
+ StateUtils.isStateful(stagePayload)
Review comment:
This logic to extract key coder from a portable pipeline is only used
here. It is different from classic pipeline approach and depends on different
inputs.
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java
##########
@@ -112,8 +113,10 @@ public void translate(
.collect(
Collectors.toMap(e -> e.getKey(), e -> ((PCollection<?>)
e.getValue()).getCoder()));
- boolean isStateful = DoFnSignatures.isStateful(transform.getFn());
- final Coder<?> keyCoder = isStateful ? ((KvCoder<?, ?>)
input.getCoder()).getKeyCoder() : null;
+ final Coder<?> keyCoder =
+ StateUtils.isStateful(transform.getFn())
Review comment:
This logic to extract key coder from a classic pipeline is only used
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
