lostluck commented on a change in pull request #15289:
URL: https://github.com/apache/beam/pull/15289#discussion_r685387873
##########
File path: sdks/go/pkg/beam/core/runtime/harness/harness.go
##########
@@ -305,7 +313,7 @@ func (c *control) handleInstruction(ctx context.Context,
req *fnpb.InstructionRe
data.Close()
state.Close()
- mons, pylds := monitoring(plan)
+ mons, pylds := monitoring(plan, store)
Review comment:
I tried only having the payloads, but Dataflow doesn't produce the
metrics at all then, so we'll keep the monitoring infos around until Dataflow
handles only payloads properly.
There might be an experiment to toggle to fix this, but there's no harm in
the SDK waiting for the default to switch (other than the wire cost of not
being exclusively on the short id requests & payload duplication).
See
https://console.cloud.google.com/dataflow/jobs/us-central1/2021-08-09_10_24_28-7240084760069835414?project=google.com:clouddfe
which has both, vs
https://console.cloud.google.com/dataflow/jobs/us-central1/2021-08-09_10_00_52-11618126016479762400?project=google.com:clouddfe
which is just the payloads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
