scwhittle commented on a change in pull request #15301:
URL: https://github.com/apache/beam/pull/15301#discussion_r686251237
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystems.java
##########
@@ -317,6 +317,10 @@ public static void rename(
return;
}
+ // XXX: Instead of filtering here we should pass options on to filesystem
as it will be able to
Review comment:
I'm leaving XXX for things I don't want to submit
I am pushing this for a preliminary review that it doesn't seem broken and
then so we can load test with it. It definitely has warts that need to be
addressed before submiting but we can do that if it turns out to be beneficial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
