chamikaramj commented on a change in pull request #15301:
URL: https://github.com/apache/beam/pull/15301#discussion_r687082094
##########
File path:
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/s3/S3FileSystem.java
##########
@@ -545,7 +546,9 @@ CompleteMultipartUploadResult multipartCopy(
@Override
protected void rename(
- List<S3ResourceId> sourceResourceIds, List<S3ResourceId>
destinationResourceIds)
+ List<S3ResourceId> sourceResourceIds,
+ List<S3ResourceId> destinationResourceIds,
+ MoveOptions... moveOptions)
Review comment:
We should raise an UnsupportedOperationexception for this and other
FileSystems when MoveOptions that are not fully supported are used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
