scwhittle commented on a change in pull request #15301:
URL: https://github.com/apache/beam/pull/15301#discussion_r687127247
##########
File path:
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/s3/S3FileSystem.java
##########
@@ -545,7 +546,9 @@ CompleteMultipartUploadResult multipartCopy(
@Override
protected void rename(
- List<S3ResourceId> sourceResourceIds, List<S3ResourceId>
destinationResourceIds)
+ List<S3ResourceId> sourceResourceIds,
+ List<S3ResourceId> destinationResourceIds,
+ MoveOptions... moveOptions)
Review comment:
Done, changed FileSystems to catch the exception and retry without move
options to keep existing behavior for filesystems that don't support options.
I also fixed bug where I wasn't forwarding on the move options as I thought
to the filesystem in FileSystems.rename ( and thus wasn't using the improved
error handling in GcsFileSystem)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
