benWize commented on pull request #15174: URL: https://github.com/apache/beam/pull/15174#issuecomment-910668690
> There is one ZetaSQL compliance test failure. (ZetaSQL is mostly open source but its compliance tests are not yet, so we usually end up duplicating the tests in Beam where necessary.) > > It seems we are not handling this case properly: Returns NULL if the input contains only NULLs. (from https://github.com/google/zetasql/blob/master/docs/aggregate_functions.md#sum) > > Can you write a test for this case and fix it? I added the test, and fix the null handling case, but I had to branch `SUM` and `SUM0` logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
