benWize commented on pull request #15174: URL: https://github.com/apache/beam/pull/15174#issuecomment-918647393
@ibzib I copied most of the tests to check the fixes, I was able to fix null handling for `BitOr` and `BitAnd`, but in the case of `BitXOr` and `Array_Agg` it shows an error because the `inferedType` by Calcite is BIGINT NOT NULL, so when trying to return `null` (Like in an empty input) fails by type mismatch (`ARRAY<INT64 NOT NULL> NOT NULL is not nullable`). https://github.com/apache/beam/blob/8adc4370e462ce9c1c0eb7472aea53be707d7cd5/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java#L259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
