chamikaramj commented on a change in pull request #15454:
URL: https://github.com/apache/beam/pull/15454#discussion_r702203714
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -849,10 +851,16 @@ private Debuggee registerDebuggee(CloudDebugger
debuggerClient, String uniquifie
}
}
- private List<DataflowPackage> stageArtifacts(RunnerApi.Pipeline pipeline) {
+ private Pair<List<DataflowPackage>, RunnerApi.Pipeline> stageArtifacts(
+ RunnerApi.Pipeline pipeline) {
+ RunnerApi.Pipeline.Builder pipelineBuilder = pipeline.toBuilder();
+ RunnerApi.Components.Builder componentsBuilder =
pipelineBuilder.getComponentsBuilder();
+ componentsBuilder.clearEnvironments();
Review comment:
How does clearing environments from the builder help ?
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -849,10 +851,16 @@ private Debuggee registerDebuggee(CloudDebugger
debuggerClient, String uniquifie
}
}
- private List<DataflowPackage> stageArtifacts(RunnerApi.Pipeline pipeline) {
+ private Pair<List<DataflowPackage>, RunnerApi.Pipeline> stageArtifacts(
+ RunnerApi.Pipeline pipeline) {
+ RunnerApi.Pipeline.Builder pipelineBuilder = pipeline.toBuilder();
+ RunnerApi.Components.Builder componentsBuilder =
pipelineBuilder.getComponentsBuilder();
+ componentsBuilder.clearEnvironments();
ImmutableList.Builder<StagedFile> filesToStageBuilder =
ImmutableList.builder();
for (Map.Entry<String, RunnerApi.Environment> entry :
pipeline.getComponents().getEnvironmentsMap().entrySet()) {
+ RunnerApi.Environment.Builder environmentBuilder =
entry.getValue().toBuilder();
+ environmentBuilder.clearDependencies();
Review comment:
How does clearing dependencies from the environment help ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
