chamikaramj commented on a change in pull request #15454:
URL: https://github.com/apache/beam/pull/15454#discussion_r703094345
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -950,8 +1002,10 @@ public DataflowPipelineJob run(Pipeline pipeline) {
.addAllCapabilities(Environments.getJavaCapabilities())
.build());
- RunnerApi.Pipeline portablePipelineProto =
+ RunnerApi.Pipeline pipelineProto =
PipelineTranslation.toProto(pipeline, portableComponents, false);
+ List<DataflowPackage> packages = stageArtifacts(pipelineProto);
+ RunnerApi.Pipeline portablePipelineProto = resolveArtifacts(pipelineProto);
Review comment:
We should use a single variable instead of maintaining multiple
variables for the pipeline for here and below (pipelineProto and
portablePipelineProto)
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -950,8 +1002,10 @@ public DataflowPipelineJob run(Pipeline pipeline) {
.addAllCapabilities(Environments.getJavaCapabilities())
.build());
- RunnerApi.Pipeline portablePipelineProto =
+ RunnerApi.Pipeline pipelineProto =
PipelineTranslation.toProto(pipeline, portableComponents, false);
+ List<DataflowPackage> packages = stageArtifacts(pipelineProto);
Review comment:
Add a comment that this has to be invoked before the "resolveArtifacts"
call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
