ibzib commented on pull request #15502: URL: https://github.com/apache/beam/pull/15502#issuecomment-921139167
> Also, the call to FileSystems.setDefaultPipelineOptions seems like a bit of a hack that is sprinkled all across the codebase; I'm not sure what the plan is for improving this so sorry for this PR just making it worse. I don't think there's a plan to improve this. FWIW I think `FileSystems.setDefaultPipelineOptions` is inadequately named; it should be probably be called `FileSystems.registerFileSystems` or something that more clearly conveys its purpose. I don't think createServerInfo is the best place to do this. createServerInfo is runner-agnostic, and it shouldn't have to know anything about file systems or the runner's JVM setup. It's better to put it up front in SparkExecutableStageFunction::call. https://github.com/apache/beam/blob/f969f9a3435ed4165f87c61d577dc5dd5de8ab47/runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkExecutableStageFunction.java#L125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
