aromanenko-dev commented on a change in pull request #15529:
URL: https://github.com/apache/beam/pull/15529#discussion_r718451640
##########
File path: runners/spark/spark_runner.gradle
##########
@@ -166,6 +166,10 @@ dependencies {
provided
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
provided "org.apache.spark:spark-sql_$spark_scala_version:$spark_version"
provided
"org.apache.spark:spark-streaming_$spark_scala_version:$spark_version"
+ runtimeOnly "org.apache.spark:spark-core_$spark_scala_version:$spark_version"
Review comment:
1. Why do we need to have two configurations (`provided` and
`runtimeOnly`) for the same deps?
2. Can you make sure that generated jars won't cause breaking changes for
users who already use any of Spark Runners?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
