echauchot commented on a change in pull request #15529:
URL: https://github.com/apache/beam/pull/15529#discussion_r719127681
##########
File path: runners/spark/spark_runner.gradle
##########
@@ -166,6 +166,10 @@ dependencies {
provided
"org.apache.spark:spark-network-common_$spark_scala_version:$spark_version"
provided "org.apache.spark:spark-sql_$spark_scala_version:$spark_version"
provided
"org.apache.spark:spark-streaming_$spark_scala_version:$spark_version"
+ runtimeOnly "org.apache.spark:spark-core_$spark_scala_version:$spark_version"
Review comment:
> Note that `provided` is used when generating the pom.xml for this
artifact to list a provided dependency.
I also took a look at the generated poms (thanks Alexey for the ping about
that) and they are exactly identical to the ones before the change for both
spark 2 and spark 3 modules. Meaning that they contain apache spark libs in
provided scope as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
