je-ik commented on a change in pull request #15665:
URL: https://github.com/apache/beam/pull/15665#discussion_r724787671
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingTransformTranslators.java
##########
@@ -159,6 +159,8 @@
new CreateViewStreamingTranslator());
TRANSLATORS.put(PTransformTranslation.RESHUFFLE_URN, new
ReshuffleTranslatorStreaming());
Review comment:
Here as well, do we still match this?
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ReshuffleTranslation.java
##########
@@ -36,26 +36,43 @@
})
public class ReshuffleTranslation {
- static class ReshuffleTranslator implements
TransformPayloadTranslator<Reshuffle<?, ?>> {
Review comment:
This looks like a breaking change. Runners that are released
independently from Beam releases (e.g. IBM streams?) might have translation for
the original URN and these will not be changed. Could we keep this URN
available and let the runner expand it, if it uses the new URNs?
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchPortablePipelineTranslator.java
##########
@@ -153,6 +153,9 @@ public static FlinkBatchPortablePipelineTranslator
createTranslator() {
translatorMap.put(
PTransformTranslation.RESHUFFLE_URN,
FlinkBatchPortablePipelineTranslator::translateReshuffle);
Review comment:
Hm, if we removed the `ReshuffleTranslator`, this will not be matched
(when produced by the Java SDK), right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
