kw2542 commented on a change in pull request #15665:
URL: https://github.com/apache/beam/pull/15665#discussion_r725147283
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ReshuffleTranslation.java
##########
@@ -36,26 +36,43 @@
})
public class ReshuffleTranslation {
- static class ReshuffleTranslator implements
TransformPayloadTranslator<Reshuffle<?, ?>> {
Review comment:
correct me if I am wrong, the registrar here is only used when
converting a Java SDK Pipeline to Portable/Protobuf Pipeline.
Since we have already updated Reshuffle.of() to return Reshuffle.PerKey
which is a PTransform with the new Urn, it should be relatively safe to remove.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
