zhoufek commented on a change in pull request #15603:
URL: https://github.com/apache/beam/pull/15603#discussion_r727129474
##########
File path: sdks/python/apache_beam/transforms/trigger.py
##########
@@ -850,7 +855,12 @@ class AfterAll(_ParallelTriggerFn):
combine_op = all
def may_lose_data(self, windowing):
- return reduce(or_, (t.may_lose_data(windowing) for t in self.triggers))
+ """If all sub-triggers may finish, then this may finish."""
Review comment:
I'm not sure if there's a difference in how Java handles triggers
finishing, but as noted in my other comment, Python's `AfterAll` will only
signal that it's finished after all its sub-triggers have signaled that they're
finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
